Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Standard 2.0 / .NET 6 targets #8

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Add .NET Standard 2.0 / .NET 6 targets #8

merged 3 commits into from
Aug 18, 2023

Conversation

RichardD2
Copy link
Contributor

@RichardD2 RichardD2 commented Aug 18, 2023

Fixes #7

@aradalvand aradalvand changed the title Restore .NET Standard 2.0 / .NET 6 targets (Main branch) Add .NET Standard 2.0 / .NET 6 targets Aug 18, 2023
@RichardD2
Copy link
Contributor Author

Looks like the EncodeAndDecode_LargeRange_ReturnsUniqueIdsAndRoundTripsSuccessfully test is timing out on the 100_000_000 case now that there are three target frameworks to test.

@aradalvand
Copy link
Collaborator

aradalvand commented Aug 18, 2023

Looks like the EncodeAndDecode_LargeRange_ReturnsUniqueIdsAndRoundTripsSuccessfully test is timing out on the 100_000_000 case now that there are three target frameworks to test.

@RichardD2 Are you sure that's the problem? I'm seeing a System.TypeInitializationException in the action logs here on the net472 test. Not sure what it means.

@RichardD2
Copy link
Contributor Author

That's odd; the tests run fine for me in Visual Studio, albeit slowly on that specific test.

Perhaps it's because the tests are running on Ubuntu, which doesn't support .NET Framework?

tests.yaml
runs-on: ubuntu-latest

And they're only configured to use .NET 7:

dotnet-version: "7.x" # TODO: Specify multiple .NET versions once we add support for other target frameworks

@aradalvand aradalvand merged commit e6d0818 into sqids:main Aug 18, 2023
1 check passed
@aradalvand
Copy link
Collaborator

aradalvand commented Aug 18, 2023

@RichardD2 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add target frameworks other than .NET 7
2 participants