Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: early exit when encoding invalid numbers #14

Merged
merged 1 commit into from
Nov 26, 2023
Merged

chore: early exit when encoding invalid numbers #14

merged 1 commit into from
Nov 26, 2023

Commits on Nov 26, 2023

  1. chore: early exit when encoding invalid numbers 

    Before this change, we checked the validity of every number during
encoding. Now, we stop if we find an invalid one.

In my testing, this was about twice as fast for invalid inputs. It had
no performance impact for valid inputs, but should theoretically avoid
an unnecessary array allocation.
    @EvanHahn
    EvanHahn committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    77e9fe3 View commit details
    Browse the repository at this point in the history