Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it in preparation? #1

Closed
roukmoute opened this issue Jul 27, 2023 · 14 comments
Closed

Is it in preparation? #1

roukmoute opened this issue Jul 27, 2023 · 14 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@roukmoute
Copy link

I've come from this link: hashids/hashids.github.io#44. As a result, I was wondering whether you've considered implementing this feature yourself in PHP, or whether you're waiting for a new maintainer to step in.

As soon as this feature is available in PHP, I'd be delighted to contribute by adapting it for Symfony, if that suits your needs. I look forward to collaborating on this project.

@miquelfire
Copy link

They might be waiting on a maintainer. I feel what is basically Hashids v2 came out way too quick, so some languages don't have active people to implement the new version.

@roukmoute
Copy link
Author

roukmoute commented Jul 28, 2023

@4kimov

I'd be delighted to take on this task if no one has started working on it yet, and if you don't intend to do it yourself. I'm ready to do my bit to move this project forward.

@miquelfire
Copy link

If you have time, go ahead. I'm just here as a user.

@4kimov
Copy link
Member

4kimov commented Jul 28, 2023

@roukmoute Thanks for pinging. Just haven't gotten to implementing PHP yet.

@vinkla Should I start or would you like to adjust https://github.com/vinkla/hashids to the new spec?

@4kimov 4kimov added enhancement New feature or request help wanted Extra attention is needed labels Jul 28, 2023
@vinkla
Copy link
Collaborator

vinkla commented Jul 28, 2023

@vinkla Should I start or would you like to adjust vinkla/hashids to the new spec?

Thank you for asking. Please go ahead and start. Unfortunately, I don't have much time at the moment. I can assist you with Laravel integration later. You can refer to this repository for my initial attempt, in case it is helpful.

@4kimov
Copy link
Member

4kimov commented Jul 28, 2023

@vinkla Cool, will do. Thanks for the heads up.


I'd be delighted to take on this task if no one has started working on it yet

@roukmoute Are you referring to the core PHP library or Symfony integration?

@roukmoute
Copy link
Author

roukmoute commented Jul 29, 2023

@4kimov To begin with, I'm going to focus on the PHP library

Thanks @vinkla for the attempt 👍

@vinkla
Copy link
Collaborator

vinkla commented Jul 29, 2023

@roukmoute Ivan published 0.0.1 yesterday, please see the main branch.

@roukmoute
Copy link
Author

Thank you for this information. I was not aware of this update. I suppose it would be better to wait for a stable release and I'll concentrate on the Symfony version afterwards.

@vinkla
Copy link
Collaborator

vinkla commented Jul 29, 2023

I believe you can proceed with the Symfony version. There won't be many changes. I have a ready-to-use Laravel package. I suggest publishing it as sqids/laravel. It would be a good idea to name the Symfony package as sqids/symfony. Let's wait for @4kimov's opinion on this.

@4kimov
Copy link
Member

4kimov commented Jul 29, 2023

Hey all, quick update on the repo:

  • Main lib is there, but needs lots of cleanup
  • Tests are also there, but also need lots of cleanup
  • Math functions need to be replaced with bcmath/gmp
  • I'm sure the repo needs lots of general cleanup, @vinkla is already helping with that

I registered v0.0.1 just so there's something there. Regarding framework support / plugins, I think they're more appropriate for individual user repositories, so feel free to create them under your own usernames. I'd like the sqids Github org to be supporting the 40+ core libs, so that they're a solid foundation to build on top of. If framework repos are under the same roof, it might get a bit too busy.

As far as this repo, if anyone wants to bring it to the finish line, by all means; otherwise, I'll wrap it up hopefully in a few days.

@vinkla
Copy link
Collaborator

vinkla commented Jul 29, 2023

A Laravel version is currently being developed: https://github.com/vinkla/sqids

@tobsn
Copy link

tobsn commented Feb 13, 2024

is there no salt available?

@4kimov
Copy link
Member

4kimov commented Feb 13, 2024

@tobsn

why removed: https://sqids.org/faq#salt
how to have unique ids: https://sqids.org/faq#unique

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants