Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running rework with a subdirectory that has not been manually created fails #686

Closed
jfeaver opened this issue Nov 15, 2022 · 3 comments · Fixed by #689
Closed

Running rework with a subdirectory that has not been manually created fails #686

jfeaver opened this issue Nov 15, 2022 · 3 comments · Fixed by #689
Assignees
Labels

Comments

@jfeaver
Copy link

jfeaver commented Nov 15, 2022

While using Sqitch version 1.3.1, I have a plan that has added tables/users in a previous tag. There have been no reworks in this project. When I run sqitch rework -m "Add stuff to users" tables/users then I get an error and no files are generated. The error is this:

Cannot copy sql/revert/tables/users.sql to sql/_reworked/revert/tables/users@1.0.0.sql: No such file or directory

Expected behaviour: Sqitch should create directories and files that it needs to make the rework command succeed.

Workaround: I can create the directories manually: mkdir -p sql/_reworked/deploy/tables sql/_reworked/revert/tables sql/_reworked/verify/tables

@theory
Copy link
Collaborator

theory commented Nov 20, 2022

Hav you set reworked_dir to _reworked?

@theory
Copy link
Collaborator

theory commented Nov 20, 2022

Apparently so, replicated the issue.

theory added a commit that referenced this issue Nov 20, 2022
Add tests to make sure it works as expected. Resolves #686.
@theory theory self-assigned this Nov 20, 2022
@theory theory added bug patched Fixed in a branch but not yet merged. labels Nov 20, 2022
@jfeaver
Copy link
Author

jfeaver commented Nov 21, 2022

Thank you!

@theory theory closed this as completed in ef7767d Nov 27, 2022
@theory theory removed the patched Fixed in a branch but not yet merged. label Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants