Update IPC::System::Simple check on Win32. #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out 1.26 was released last month without the fix for Win32. Today, however, pjf/ipc-system-simple#29 was merged and a 1.27 trial release made, so it seems likely the fix will be released in 1.27. So update the workaround here to operate on 1.26 and earlier.
theory
force-pushed
the
ipc-system-simple-version
branch
from
34f7171
to
a49388b
Compare
|
Would you mind giving this a review, @autarch? ISTR you were keeping an eye on the IPC::System::Simple Win32 bug, too. |
autarch
approved these changes
May 1, 2020
|
Thanks @autarch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out 1.26 was released in January without the fix for Win32. Recently, however, pjf/ipc-system-simple#29 was merged and 1.28 released, fixing the Win32 issue. So update the workaround here to operate on 1.27 and earlier. Resolves #478.