Add MySQL 5.7 support

[vladsf]

Add fixes to support MySQL 5.7

[theory]

Thanks. I wonder if we need to include instructions for older versions of MySQL, too? Or is 8 old enough now that we can just standardize on it? If the latter, would you mind adding a note near the top that the examples assume MySQL 8? Thanks!

[vladsf]

MySQL 8 is old enough. Released 5 years ago. I am replacing 5.5 links and with 5.6, new routines tables were introduced in 5.6 (https://dev.mysql.com/doc/refman/5.6/en/routines-table.html)

…

On Sun, Jan 29, 2023, 00:11 David E. Wheeler ***@***.***> wrote: Thanks. I wonder if we need to include instructions for older versions of MySQL, too? Or is 8 old enough now that we can just standardize on it? If the latter, would you mind adding a note near the top that the examples assume MySQL 8? Thanks! — Reply to this email directly, view it on GitHub <#705 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA663HFD26DPLX7L4E7KDI3WUVVOXANCNFSM6AAAAAAUI6KSXI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[vladsf]

I found another problem: ENCRYPT() function was deprecated in MySQL 5.7 and removed in MySQL 8.0. SHA2() was recommended to use (https://dev.mysql.com/doc/refman/5.7/en/encryption-functions.html#function_sha2) instead.

[vladsf]

ENCRYPT() call might be replaced with:
SHA2(CONCAT(HEX(RANDOM_BYTES(2)), 'password'), 256)
then the whole code will be 8.0 compatible otherwise it requires 5.[6,7]

[theory]

ENCRYPT() call might be replaced with:
SHA2(CONCAT(HEX(RANDOM_BYTES(2)), 'password'), 256)
then the whole code will be 8.0 compatible otherwise it requires 5.[6,7]

Sounds good, if you want to add that I'll get it merged. Thank you!

[vladsf]

Examined the rest of the code. Removing ENCRYPT() breaks the consistency of the tutorial. Some filenames have encrypt in the names, etc. I suggest to stay compatible with MySQL 5.7. This version is available on the official MySQL Docker page.
Let this a patch be a step towards MySQL 8.

[vladsf]

@theory any updates?

[theory]

Nope, been completely heads-down on a project at work, plus a mini-project to move the PGXN bot from Twitter to Mastodon. I'll get to it, but it might be a couple weeks.

[theory]

Looks good, just one Pod bit that needs fixing.