Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor strict mode #735

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Refactor strict mode #735

merged 2 commits into from
Apr 12, 2023

Conversation

theory
Copy link
Collaborator

@theory theory commented Apr 3, 2023

Build on #719. Remove the attribute from RevertDeployCommand and handle it in the configure method. Remove redundant logic from revert.pm. Tweak the docs and remove the incorrect statement that -y overrides strict mode. Note the new feature in Changes and credit @vectro. Also fix a few typos in test descriptions.

@theory theory requested a review from autarch April 3, 2023 01:45
@theory theory mentioned this pull request Apr 3, 2023
Closed
@coveralls
Copy link

coveralls commented Apr 3, 2023 •
edited

Pull Request Test Coverage Report for Build 4653710485

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 99.889%
Files with Coverage Reduction New Missed Lines %
lib/App/Sqitch.pm 1 99.52%
Totals Coverage Status
Change from base Build 4653563956: -0.02%
Covered Lines: 4487
Relevant Lines: 4492
💛 - Coveralls

vectro
vectro suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@vectro vectro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than my one other comment.

lib/App/Sqitch/Command/revert.pm Outdated Show resolved Hide resolved
@theory
Add a new strict-mode configuration option, which disables some
e54f17d 
functionality that could be perceived as creating risks to production
environments.
@theory
Copy link
Collaborator Author

theory commented Apr 10, 2023

Rebased onto develop in cb939e9.

@theory theory requested a review from vectro April 10, 2023 01:52
@theory
Refactor strict mode
1bc3102 
Remove the attribute from RevertDeployCommand and handle it in the
configure method. Remove redundant logic from revert.pm. Tweak the
docs and remove the incorrect statement that `-y` overrides strict
mode. Note the new feature in Changes and credit @vectro. Also fix
a few typos in test descriptions.
@theory theory merged commit 1bc3102 into develop Apr 12, 2023
124 checks passed
@theory theory deleted the vectro-strict branch April 12, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vectro vectro vectro approved these changes

@autarch autarch Awaiting requested review from autarch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theory @coveralls @vectro