Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cockroachdb #772

Closed
wants to merge 3 commits into from
Closed

Fix cockroachdb #772

wants to merge 3 commits into from

Conversation

NOBLES5E
Copy link

@NOBLES5E NOBLES5E commented Jul 26, 2023

Since cockroach is not listed in https://github.com/sqitchers/sqitch/blob/v1.3.1/lib/App/Sqitch/Command.pm#L17, there's no way to specify engine as cockroach.

@NOBLES5E NOBLES5E changed the title Fix incorrect documentation for cockroachdb Fix cockroachdb Jul 26, 2023
@theory
Copy link
Collaborator

theory commented Jul 29, 2023

Thank you, can't believe I missed this. Closing in favor #774, which also adds a test to ensure it doesn't happen again.

@theory theory closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants