Update readme.md for use with Webpack 5 #24
Conversation
|
Maybe you could update the code itself to use the latest react and webpack ? https://github.com/sql-js/react-sqljs-demo/blob/master/package.json |
|
I've started with that, but I think many people are still with Webpack 4. So i've just updated the readme. Tell me what you prefer :) |
|
I think we can update the code to the latest versions, and just leave a link in the readme to the version using webpack 4. I tagged the current state of the repo as v1, so you can link to https://github.com/sql-js/react-sqljs-demo/tree/v1 |
| 'path': require.resolve('path-browserify'), | ||
| 'crypto': require.resolve('crypto-browserify'), | ||
| 'stream': require.resolve('stream-browserify') |
There was a problem hiding this comment.
Do we actually use path, crypto and stream anywhere ?
There was a problem hiding this comment.
that a good question, and honestly I don"t really know how webpack handle wasm, nor how sql.js is built.
My point is everything was working fine for me with Webmact4, and when updating to Webpack5 I had 3 successive errors saying "path", "crypto" and "stream" are not included as polyfill (comming from sql.js/dist), , and adding these lines fixed the error and everything run again smoothly
There was a problem hiding this comment.
We should probably avoid encouraging users to bundle three dependencies they don't need with their code.
There was a problem hiding this comment.
In addition to path, crypto and stream, I've just encountered another error related to fs. It seems that setting the fallback of fs to false got it working for me. Is there a chance other dependencies can be set to false as well?
config.resolve.fallback = {
'fs': false,
'path': false,
'crypto': false,
'stream': false
}Edit: This seems to be working for my other repository using TypeORM + Sql.js + Expo Web! Requires further testing on React + Sql.js though I believe it should work the same.
No description provided.