Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load test.db sqlite database demo file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eSlider
Copy link

@eSlider eSlider commented Jun 14, 2020

As discussed in previous PR I improved live-demo by add database file load example to become abilities run SQL queries on it.

Changes

  • Download demo sqlite database file using fetch
  • Prepare downloaded file to handle it right ( ArrayBuffer => Uint8Array )
  • Add default select SQL query in textearea

Copy link
Member

@lovasoa lovasoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Two little things :

  • it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
  • The default query should be executed immediately once the database has been loaded.

@eSlider
Copy link
Author

eSlider commented Jun 15, 2020

Nice !

Two little things :

  • it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
  • The default query should be executed immediately once the database has been loaded.

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

@lovasoa
Copy link
Member

lovasoa commented Jun 15, 2020

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

The Dallas Police Officer-Involved Shootings is great. It is small enough to load quickly, is not copyrighted, and contains interesting public data, with several tables that can be joined. If you find or create another database that meets these criteria and want to include it instead, go ahead; but I don't think the Dallas PD data has any reason for being controversial.

zmwm37 added a commit to zmwm37/react-sqljs-demo that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants