Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 tutorial document #1124

Merged
merged 13 commits into from Sep 12, 2019
Merged

101 tutorial document #1124

merged 13 commits into from Sep 12, 2019

Conversation

QiJune
Copy link
Collaborator

@QiJune QiJune commented Sep 5, 2019

Fix #1115

@QiJune QiJune changed the title 101 tutorial document [WIP]101 tutorial document Sep 5, 2019
@QiJune QiJune changed the title [WIP]101 tutorial document 101 tutorial document Sep 9, 2019

## ElasticDL on cluster

TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem ready for review yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it later

```bash
brew install kubectl
brew cask install minikube
brew install docker-machine-driver-hyperkit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just link to minikube installation documentation? (users may not want to use brew) Also users should just select their own driver (users may not want to use this driver). We can point to a reference to hyperkit if needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will remove it.


## Environment prepare

Here, we use macbook as our expriment environment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to mention this if we just put a reference to minikube installation guide.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


## Write model file

We use Tensorflow Keras API to build our models. For details, please refer to [ModelBuilding](https://github.com/sql-machine-learning/elasticdl/blob/develop/elasticdl/doc/model_building.md) part.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TensorFlow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "part".

"Please refer to this tutorial on model building for details."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

### Summit a training job


You have to set right docker environment. Please run `minikube docker-env` to get docker host url and docker cert path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You have to set right docker environment" -> "There are other docker settings that you might also want to configure prior to submitting the training job"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

--output=model_output
```

After summit the job to minikubes, you can run following command to check the status of each pod:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minikubes -> minikube
summit -> submitting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

kubectl get pods
```

You will get messages like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"You should see information on each pod like the following"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,35 @@
# 101 Tutorial

101 tutorial contains a series of documents which covers ElasticDL usage under different scenarios: local computer/private cluster/public cloud. It aims to help users get hands on quickly and have a preliminary understanding of ElasticDL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

101 tutorial -> this tutorial

@@ -0,0 +1,35 @@
# 101 Tutorial

101 tutorial contains a series of documents which covers ElasticDL usage under different scenarios: local computer/private cluster/public cloud. It aims to help users get hands on quickly and have a preliminary understanding of ElasticDL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use markdown bullets for these scenarios


## ElasticDL on local

Minikube is a tool that makes it easy to run Kubernetes locally. Minikube runs a single-node Kubernetes cluster inside a Virtual Machine (VM) on your laptop for users looking to try out Kubernetes or develop with it day-to-day. Here we use Minikube to run ElasticDL in local laptop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent uses of "you" and "users". Better to be consistent across the doc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,35 @@
# 101 Tutorial
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's better to be called "Getting Started with ElasticDL" similar to https://www.tensorflow.org/tutorials. "101" seems a bit informal and people from other countries may not understand what this means.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

--image_base=elasticdl:ci \
--cluster_spec=$CLUSTER_SPEC \
--model_zoo=./model_zoo \
--docker_image_prefix=$DOCKER_HUB_REPO \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readers might be confused about what DOCKER_HUB_REPO and CLUSTER_SPEC refers to. Perhaps add some descriptions on those


You should install ElasticDL first. Please refer to the installation part in [elastic_local](./elasticdl_local.md) doc.

Then, please build needed images.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "please"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

--namespace=kubemaker
```

It will build a image locally and push to the remote docker hub. And then the job will be launched on the cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a image -> an image
". And then" -> " and then"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


- https://kubernetes.io/docs/setup/learning-environment/minikube/


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing empty lines

@QiJune QiJune merged commit 128d3b7 into sql-machine-learning:develop Sep 12, 2019
@QiJune QiJune deleted the 101_doc branch September 12, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a 101 user guide
7 participants