New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
101 tutorial document #1124
101 tutorial document #1124
Conversation
elasticdl/doc/tutorials/101.md
Outdated
|
||
## ElasticDL on cluster | ||
|
||
TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't seem ready for review yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add it later
```bash | ||
brew install kubectl | ||
brew cask install minikube | ||
brew install docker-machine-driver-hyperkit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just link to minikube installation documentation? (users may not want to use brew) Also users should just select their own driver (users may not want to use this driver). We can point to a reference to hyperkit if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will remove it.
|
||
## Environment prepare | ||
|
||
Here, we use macbook as our expriment environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to mention this if we just put a reference to minikube installation guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
## Write model file | ||
|
||
We use Tensorflow Keras API to build our models. For details, please refer to [ModelBuilding](https://github.com/sql-machine-learning/elasticdl/blob/develop/elasticdl/doc/model_building.md) part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TensorFlow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "part".
"Please refer to this tutorial on model building for details."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
### Summit a training job | ||
|
||
|
||
You have to set right docker environment. Please run `minikube docker-env` to get docker host url and docker cert path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"You have to set right docker environment" -> "There are other docker settings that you might also want to configure prior to submitting the training job"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
--output=model_output | ||
``` | ||
|
||
After summit the job to minikubes, you can run following command to check the status of each pod: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minikubes -> minikube
summit -> submitting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
kubectl get pods | ||
``` | ||
|
||
You will get messages like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"You should see information on each pod like the following"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
elasticdl/doc/tutorials/101.md
Outdated
@@ -0,0 +1,35 @@ | |||
# 101 Tutorial | |||
|
|||
101 tutorial contains a series of documents which covers ElasticDL usage under different scenarios: local computer/private cluster/public cloud. It aims to help users get hands on quickly and have a preliminary understanding of ElasticDL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
101 tutorial -> this tutorial
elasticdl/doc/tutorials/101.md
Outdated
@@ -0,0 +1,35 @@ | |||
# 101 Tutorial | |||
|
|||
101 tutorial contains a series of documents which covers ElasticDL usage under different scenarios: local computer/private cluster/public cloud. It aims to help users get hands on quickly and have a preliminary understanding of ElasticDL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use markdown bullets for these scenarios
elasticdl/doc/tutorials/101.md
Outdated
|
||
## ElasticDL on local | ||
|
||
Minikube is a tool that makes it easy to run Kubernetes locally. Minikube runs a single-node Kubernetes cluster inside a Virtual Machine (VM) on your laptop for users looking to try out Kubernetes or develop with it day-to-day. Here we use Minikube to run ElasticDL in local laptop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent uses of "you" and "users". Better to be consistent across the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
elasticdl/doc/tutorials/101.md
Outdated
@@ -0,0 +1,35 @@ | |||
# 101 Tutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it's better to be called "Getting Started with ElasticDL" similar to https://www.tensorflow.org/tutorials. "101" seems a bit informal and people from other countries may not understand what this means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
--image_base=elasticdl:ci \ | ||
--cluster_spec=$CLUSTER_SPEC \ | ||
--model_zoo=./model_zoo \ | ||
--docker_image_prefix=$DOCKER_HUB_REPO \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readers might be confused about what DOCKER_HUB_REPO
and CLUSTER_SPEC
refers to. Perhaps add some descriptions on those
|
||
You should install ElasticDL first. Please refer to the installation part in [elastic_local](./elasticdl_local.md) doc. | ||
|
||
Then, please build needed images. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "please"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
--namespace=kubemaker | ||
``` | ||
|
||
It will build a image locally and push to the remote docker hub. And then the job will be launched on the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a image -> an image
". And then" -> " and then"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
- https://kubernetes.io/docs/setup/learning-environment/minikube/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing empty lines
Fix #1115