add a test for deepfm #1442
Merged
add a test for deepfm #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
commented
Nov 12, 2019
| "ElasticDL Tensor ignores dense_shape in " | ||
| "TensorFlow.IndexedSlices." | ||
| ) | ||
| # TODO(yunjian.lmh): Support dense shape |
There was a problem hiding this comment.
This will generate too many warnings. So I remove it.
| ): | ||
| self.expected_embed_table[gi] -= self._lr * gv | ||
|
|
||
| self.embedding_grads1 = tf.IndexedSlices( |
There was a problem hiding this comment.
Just to address the issue here, refine the unit test.
mhaoli
reviewed
Nov 12, 2019
| y, | ||
| ) | ||
| acc = acc_meter.result().numpy() | ||
| print("loss: ", w_loss.numpy(), " acc: ", acc) |
| @@ -266,6 +270,67 @@ def test_worker_pull_embedding(self): | |||
| expected_result = np.concatenate(expected_result) | |||
| self.assertTrue(np.allclose(expected_result, result_dict[layer])) | |||
|
|
|||
| def test_deepfm_train(self): | |||
There was a problem hiding this comment.
Extract the common training logic of test_deepfm_train and test_mnist_train as a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1441