build docker image using docker py client #322
Conversation
| @@ -31,7 +33,9 @@ def _build_docker_image(m_path, m_file, m_file_in_docker, timestamp): | |||
|
|
|||
| with open(new_dfile, 'a') as df: | |||
| df.write("COPY " + m_file + " " + m_file_in_docker) | |||
There was a problem hiding this comment.
Avoid creating temp file, and manual path join if possible:
docker_file = open(os.path.join(d_path, "..", "Dockerfile.dev")).read() + "\nCOPY {m_file} {m_file_in_docker}\n".format(**locals())
fileobj = BytesIO(docker_file.encode())
... client.build(fileobj=fileobj, rm=True, tag=...)...
There was a problem hiding this comment.
it seems that the param path which specifies the build context is ignored when the param fileobj is used, see docker/docker-py#2105, so we could not execute the cmd COPY . /elasticdl in dockerfile to copy elasticdl source code into container.
There was a problem hiding this comment.
it seems that the param
pathwhich specifies the build context is ignored when the paramfileobjis used, see docker/docker-py#2105, so we could not execute the cmdCOPY . /elasticdlin dockerfile to copy elasticdl source code into container.
That's good to know.
There was a problem hiding this comment.
I've made a PR with the fix. It might be the best way to handle it, due to the that it will directly be forwarded to docker compose.
docker/docker-py#2456
fix #317