Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorize the API of codegen.go #77

Closed
wangkuiyi opened this issue Nov 27, 2018 · 1 comment · Fixed by #80
Closed

Refactorize the API of codegen.go #77

wangkuiyi opened this issue Nov 27, 2018 · 1 comment · Fixed by #80
Milestone
First Prototype (...

Comments

@wangkuiyi
Copy link
Collaborator

There should be a function named something like codegen or generateCode in codegen.go, like parse in paser.go and verify in verifier.go.
@wangkuiyi
Copy link
Collaborator Author

Also, we should not export type TemplateFiller, which should be used privately by generateCode and renamed to start with an uncapitalized letter.

@wangkuiyi wangkuiyi mentioned this issue Nov 27, 2018
Closed
@tonyyang-svail tonyyang-svail mentioned this issue Nov 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First Prototype (sql parser, mysql, a...
Development

Successfully merging a pull request may close this issue.

refactor codegen.go
1 participant
@wangkuiyi