Move feature derivation #1616
Merged
Move feature derivation #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
previously approved these changes
Jan 6, 2020
pkg/step/feature/derivation.go
Outdated
| @@ -386,7 +386,7 @@ func InferFeatureColumns(trainStmt *ir.TrainStmt, dataSource string) error { | |||
|
|
|||
| // set back trainStmt.Features in the order of select | |||
| for _, target := range columnTargets { | |||
| targetFeatureColumnMap := fcMap[target] | |||
| targetColumnMap := fcMap[target] | |||
There was a problem hiding this comment.
The original name targetFeatureColumnMap refers to Tensorflow feature column, maybe it's better than ColumnMap?
There was a problem hiding this comment.
I see. I will follow your suggestion and change it back
typhoonzero
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/featurederivationtopkg/step/featurepkg/featurederivation/feature_derivation*.gotopkg/step/feature/derivation*.gofeaturederivation.FeatureColumnMaptofeature.ColumnMapfeaturederivation.LogFeatureDerivationResulttofeature.LogDerivationResult.