-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyalisa #3107
pyalisa #3107
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3107 +/- ##
===========================================
- Coverage 50.93% 50.46% -0.47%
===========================================
Files 248 250 +2
Lines 18493 18614 +121
===========================================
- Hits 9419 9394 -25
- Misses 8378 8524 +146
Partials 696 696
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -168,12 +166,12 @@ def read_logs(self, task_id, offset, w): | |||
params["AlisaTaskId"] = task_id | |||
params["Offset"] = str(offset) | |||
log = self._requet_and_parse_response("GetAlisaTaskLog", params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_requet_and_parse_response -> _request_and_parse_response
Sorry, this is a legacy problem. Please refine it on next commit.
Add
pyalisa
to support dbapi.