Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyalisa #3107

Merged
merged 21 commits into from
Dec 1, 2020
Merged

pyalisa #3107

merged 21 commits into from
Dec 1, 2020

Conversation

weiguoz
Copy link
Collaborator

@weiguoz weiguoz commented Nov 30, 2020

Add pyalisa to support dbapi.

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

Merging #3107 (c91d3ae) into develop (5c48b9b) will decrease coverage by 0.46%.
The diff coverage is 18.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3107      +/-   ##
===========================================
- Coverage    50.93%   50.46%   -0.47%     
===========================================
  Files          248      250       +2     
  Lines        18493    18614     +121     
===========================================
- Hits          9419     9394      -25     
- Misses        8378     8524     +146     
  Partials       696      696              
Impacted Files Coverage Δ
python/runtime/dbapi/pyalisa/client.py 26.82% <7.14%> (-1.51%) ⬇️
python/runtime/dbapi/pyalisa/config.py 22.22% <11.76%> (-77.78%) ⬇️
python/runtime/dbapi/pyalisa/pop.py 40.00% <12.50%> (-0.75%) ⬇️
python/runtime/dbapi/pyalisa/config_test.py 25.58% <14.28%> (-71.39%) ⬇️
python/runtime/dbapi/pyalisa/task_test.py 20.33% <20.33%> (ø)
python/runtime/dbapi/pyalisa/task.py 29.26% <29.26%> (ø)
python/runtime/dbapi/pyalisa/client_test.py 36.00% <50.00%> (+6.96%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c48b9b...c91d3ae. Read the comment docs.

Copy link
Collaborator

@lhw362950217 lhw362950217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -168,12 +166,12 @@ def read_logs(self, task_id, offset, w):
params["AlisaTaskId"] = task_id
params["Offset"] = str(offset)
log = self._requet_and_parse_response("GetAlisaTaskLog", params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_requet_and_parse_response -> _request_and_parse_response
Sorry, this is a legacy problem. Please refine it on next commit.

@weiguoz weiguoz merged commit a0ddf7b into sql-machine-learning:develop Dec 1, 2020
@weiguoz weiguoz deleted the pyalisa_r3 branch December 1, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants