Switch to column keyword arguments #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
requested changes
Mar 18, 2019
sqlalchemy_redshift/dialect.py
Outdated
| @@ -26,6 +26,7 @@ | |||
| pass | |||
| else: | |||
| from alembic.ddl.base import RenameTable | |||
|
|
|||
There was a problem hiding this comment.
Can you revert whitespace changes or refactor them to a separate PR?
There was a problem hiding this comment.
I can, but for some reason this particular whitespace was causing travis build to fail
sqlalchemy_redshift/dialect.py
Outdated
| @@ -254,7 +255,9 @@ class RedshiftDDLCompiler(PGDDLCompiler): | |||
| ... metadata, | |||
| ... sa.Column('id', sa.Integer, primary_key=True), | |||
| ... sa.Column( | |||
| ... 'name', sa.String, info={'distkey': True, 'sortkey': True} | |||
| ... 'name', sa.String, | |||
There was a problem hiding this comment.
Can we either split these to separate lines, or roll the last two options onto this same line for better consistency?
|
@ms32035 - If you make the whitespace and docs changes here as commented, I'll kick off CI that hits Redshift and we should be good to merge if it's all passing. |
jklukas
reviewed
Mar 19, 2019
Co-Authored-By: ms32035 <ms32035@gmail.com>
Co-Authored-By: ms32035 <ms32035@gmail.com>
jklukas
approved these changes
Mar 19, 2019
|
looks great, feel free to add me as reviewers if you have another one of these in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infoto dialect specific kwargs, which are now supported in SQLAlchemy>=1.3.0, as per recommendation from the author: https://bitbucket.org/zzzeek/alembic/pull-requests/86/add-support-for-column-info/diffinfosupport for SQLAlchemy < 1.3.0 and minimal SQLAlchemy version retainedTodos