Materialized Views for sqlalchemy-redshift#202
Merged
jklukas merged 26 commits intosqlalchemy-redshift:masterfrom May 27, 2020
Merged
Materialized Views for sqlalchemy-redshift#202jklukas merged 26 commits intosqlalchemy-redshift:masterfrom
sqlalchemy-redshift#202jklukas merged 26 commits intosqlalchemy-redshift:masterfrom
Conversation
sqlalchemy-redshift
…ent errors from compile errors
Contributor
Author
jklukas
approved these changes
May 26, 2020
Member
jklukas
left a comment
There was a problem hiding this comment.
This overall looks great and integration tests are passing, so the refactoring involved looks correct. I left a few nits to fix and otherwise this should be ready to merge.
Co-authored-by: Jeff Klukas <jeff@klukas.net>
jklukas
reviewed
May 26, 2020
Co-authored-by: Jeff Klukas <jeff@klukas.net>
jklukas
approved these changes
May 26, 2020
jklukas
approved these changes
May 27, 2020
Member
|
I just posted a new release 0.7.9 which includes this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will be creating a DDLElement that can support Redshift's CREATE MATERIALIZED VIEW with table attributes, noteably sortkeys and distkeys/styles.
Todos
table_attributesparserDefault Todos
Notes:
table_attributesparser less permissive to match expected outcomes from Redshift. I'm happy to relax this and delegate the error messages to Redshift, but it could be nice to catch them early. Up to the maintainers.Columnsin additions to strings (and iterables thereof) to be allowed to specify keys. I added the checked needed in if this is the case.ddl, since theCreateandDropqueries are normally treated somewhat differently thanExecutableorClauseElement. This was just an observation of mind, i'm happy to move it all intocommands.REFRESH MATERIALIZED VIEWSis a command. So my contribution is a little split between these two modules, perhaps awkwardly. Happy to take advice here.docfolder to reflect the new module. I haven't used Sphinx so much, but it all seemed pretty self explanatory. Even so, I'm not sure how to generate the docs to check locally. Please advise, thanks!