Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #619 completely removed support for compare_against_backend, but it's still documented #1293

Closed
CaselIT opened this issue Aug 12, 2023 · 2 comments
Labels
bug Something isn't working data types
Milestone

Comments

@CaselIT
Copy link
Member

CaselIT commented Aug 12, 2023

The PR #619 has completely removed support for compare_against_backend, but it's still documented and supposedly tested (the test is clearly broken.)

@zzzeek This seems to be a rarely used feature, since no-one reported it, but since it's still documented and all it may be better to just re-introduce it. If you feel like it make more sense removing it, then this issue could be used to remove the docs for it

Originally posted by @CaselIT in #619 (comment)

@CaselIT CaselIT changed the title PR #619 completely removed support for compare_against_backend, but it's still documented and supposedly tested PR #619 completely removed support for compare_against_backend, but it's still documented Aug 12, 2023
@CaselIT CaselIT added this to the 1.12 milestone Aug 31, 2023
@CaselIT CaselIT added bug Something isn't working data types labels Aug 31, 2023
@zzzeek
Copy link
Member

zzzeek commented Oct 17, 2023

we never fixed this; removing from the docs now

@sqla-tester
Copy link
Collaborator

Mike Bayer has proposed a fix for this issue in the main branch:

remove compare_against_backend from tests and docs https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4925

sqlalchemy-bot pushed a commit to sqlalchemy/sqlalchemy that referenced this issue Oct 20, 2023
Removed unused placeholder method :meth:`.TypeEngine.compare_against_backend`
This method was used by very old versions of Alembic.
See sqlalchemy/alembic#1293 for details.
Follow up of alembic change I6f480711ec94cd4113d3f0ca114d143b49b8d869

Change-Id: I48ba2b26128ba6f74cb0b2c54caa6f7d2a711257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data types
Projects
None yet
Development

No branches or pull requests

3 participants