Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated create_table_comment doesn't use repr for the comment parameters #549

Closed
RazerM opened this issue Apr 1, 2019 · 4 comments
Closed

Comments

@RazerM
Copy link
Contributor

@RazerM RazerM commented Apr 1, 2019

I'm on alembic 1.0.8, I think #529 only dealt with the column comments

@zzzeek
Copy link
Member

@zzzeek zzzeek commented Apr 1, 2019

Sorry I look at alembic like once a month, which parameters on which functions please? examples / PR with tests

@RazerM
Copy link
Contributor Author

@RazerM RazerM commented Apr 1, 2019

Sorry I should have provided more info in the first place:

op.create_table_comment('table_name', 'this quote isn't escaped')
op.drop_table_comment('table_name', existing_comment='this quote isn't escaped')

It may be both comment and existing_comment on both of those functions. I only had examples like above.

@zzzeek zzzeek added this to the fasttrack milestone Apr 1, 2019
@zzzeek
Copy link
Member

@zzzeek zzzeek commented Apr 1, 2019

a PR w test support would be most helpful

@sqla-tester
Copy link
Collaborator

@sqla-tester sqla-tester commented Sep 17, 2019

Mike Bayer has proposed a fix for this issue in the master branch:

Use repr for table comment in create_table_comment / drop_table_comment https://gerrit.sqlalchemy.org/1464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants