-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix constraint_name type of create_foreign_key #914
Conversation
Hi, The pyi files are auto-generated as mentioned at the top of the file, so you should update the typing and documentation in the |
Hey @CaselIT, sorry, I haven't read that particular line and didn't notice that the source files are actually typed. Are you going to squash the three commits, or shall I rework them into one? |
they will be squashed by gerrit, so it's fine to have multiple commits. I'll make the test run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision d985abb of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change d985abb: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3075 |
Since we are changing this, also create_primary_key accepts |
What about |
I guess all of the create_xx that mention that it can be None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mike bayer (zzzeek) wrote:
i say fix that pk one , then merge
View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3075
- alembic/op.pyi (line 621): yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 39d44af of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 39d44af added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3075 |
mike bayer (zzzeek) wrote: i was merging this and missed it!! 1.7.3 is right now sorry View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3075 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3075 has been merged. Congratulations! :) |
Make the type of contraint_name optional in create_foreign_key
Description
contraint_name
optional increate_foreign_key
as stated in the documentation (passingNone
will auto-generate a constraint name).Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!