New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemcachedBackend does not pass memcached_expire_time #3

Closed
sqlalchemy-bot opened this Issue Apr 23, 2012 · 5 comments

Comments

Projects
None yet
1 participant
@sqlalchemy-bot

sqlalchemy-bot commented Apr 23, 2012

Migrated issue, originally created by Justin Azoff (justinazoff)

PylibmcBackend uses memcached_expire_time and min_compress_len, but MemcachedBackend doesn't pass these through to set().

I see how to write a test that will fail, but I'm not sure how you would want this to be fixed.. I'll work on the test case..

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 23, 2012

Michael Bayer (zzzeek) wrote:

fixed in [[https://bitbucket.org/zzzeek/dogpile.cache/changeset/83ae5e5323d309ff004a7a8f3187944821499433|83ae5e5323d309ff004a7a8f3187944821499433]]

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 23, 2012

Changes by Michael Bayer (zzzeek):

  • changed status to closed
@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 23, 2012

Justin Azoff (justinazoff) wrote:

Hmm, are the tests passing for you? I may have borked something with hg and pip, but it doesn't look like it's working.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 24, 2012

Michael Bayer (zzzeek) wrote:

you can see them in this output:

SKIP: Backend dogpile.cache.bmemcached not installed
SKIP: Backend dogpile.cache.bmemcached not installed
SKIP: Backend dogpile.cache.bmemcached not installed
test_client_cleanup_1 (tests.cache.test_memcached_backend.LocalThreadTest) ... ok
test_client_cleanup_10 (tests.cache.test_memcached_backend.LocalThreadTest) ... ok
test_client_cleanup_3 (tests.cache.test_memcached_backend.LocalThreadTest) ... ok
test_set_min_compress_len (tests.cache.test_memcached_backend.MemcachedArgstest) ... ok
test_set_time (tests.cache.test_memcached_backend.MemcachedArgstest) ... ok
test_mutex (tests.cache.test_memcached_backend.MemcachedDistributedMutexTest) ... ok
test_mutex_threaded (tests.cache.test_memcached_backend.MemcachedDistributedMutexTest) ... ok
test_backend_delete (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_backend_delete_nothing (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_backend_get_nothing (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_backend_set_get_value (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_region_creator (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_region_delete (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_region_expire (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_region_set_get_nothing (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_region_set_get_value (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_threaded_dogpile (tests.cache.test_memcached_backend.MemcachedDistributedTest) ... ok
test_backend_delete (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_backend_delete_nothing (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_backend_get_nothing (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_backend_set_get_value (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_region_creator (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_region_delete (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_region_expire (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_region_set_get_nothing (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_region_set_get_value (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_threaded_dogpile (tests.cache.test_memcached_backend.MemcachedTest) ... ok
test_behaviors (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_binary_flag (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_no_set_args (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_set_min_compress_len (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_set_time (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_url_list (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_url_scalar (tests.cache.test_memcached_backend.PylibmcArgsTest) ... ok
test_mutex (tests.cache.test_memcached_backend.PylibmcDistributedMutexTest) ... ok
test_mutex_threaded (tests.cache.test_memcached_backend.PylibmcDistributedMutexTest) ... ok
test_backend_delete (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_backend_delete_nothing (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_backend_get_nothing (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_backend_set_get_value (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_region_creator (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_region_delete (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_region_expire (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_region_set_get_nothing (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_region_set_get_value (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_threaded_dogpile (tests.cache.test_memcached_backend.PylibmcDistributedTest) ... ok
test_backend_delete (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_backend_delete_nothing (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_backend_get_nothing (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_backend_set_get_value (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_region_creator (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_region_delete (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_region_expire (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_region_set_get_nothing (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_region_set_get_value (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_threaded_dogpile (tests.cache.test_memcached_backend.PylibmcTest) ... ok
test_backend_delete (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_backend_delete_nothing (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_backend_get_nothing (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_backend_set_get_value (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_region_creator (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_region_delete (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_region_expire (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_region_set_get_nothing (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_region_set_get_value (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
test_threaded_dogpile (tests.cache.test_memory_backend.MemoryBackendTest) ... ok
@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 24, 2012

Justin Azoff (justinazoff) wrote:

ah yes, I got it working now. Something was indeed hosed in the virtualenv I was using..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment