Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: Support a few more socket_* options #252

Closed
wants to merge 1 commit into from

Conversation

kajinamit
Copy link
Contributor

This introduces a native interface to tune socket_* options in Redis client.

This introduces a native interface to tune socket_* options in
Redis client.
@kajinamit
Copy link
Contributor Author

note: These options have been available since redis-py 2.10.0, which is very old, so I didn't explicitly document the version requirement.

Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision adf7a8a of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change adf7a8a: https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/5155

@zzzeek
Copy link
Member

zzzeek commented Feb 14, 2024

thanks, will see if this can be for 1.3.2 along with a new RedisCluster backend.

@zzzeek
Copy link
Member

zzzeek commented Feb 21, 2024

in the gerrit (not here) Ive rebased to main to pick up RedisClusterBackend and also did some doc format changes. https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/5155 if it passes I'll release today

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/5155 has been merged. Congratulations! :)

@kajinamit kajinamit deleted the redis-socket-opts branch February 28, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants