Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in setup.py #129

Closed
sqlalchemy-bot opened this issue Mar 5, 2010 · 6 comments
Closed

typo in setup.py #129

sqlalchemy-bot opened this issue Mar 5, 2010 · 6 comments

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Mar 5, 2010

Migrated issue, originally created by Anonymous

In setup.py (line 47) packages wants to exclude 'tests', but the real dir name is 'test'.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Michael Bayer (@zzzeek) wrote:

changed to test in 11acbbf. I know "examples" is not a package but I prefer to have it there in case an __init__.py gets added there, for example when we move to Sphinx we might want to make it into a package for doc generation purposes.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Michael Bayer (@zzzeek) wrote:

still dumping some test crap in there. investigating...

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Changes by Michael Bayer (@zzzeek):

  • changed status to reopened
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Michael Bayer (@zzzeek) wrote:

OK 838a8d6. Sorry, I'm not used to not having lib/ there even though its an antiquated convention.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 7, 2010

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant