Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .pre-commit-config as a linter and test link check #344

Open
yezz123 opened this issue Oct 25, 2021 · 1 comment
Open

Using .pre-commit-config as a linter and test link check #344

yezz123 opened this issue Oct 25, 2021 · 1 comment

Comments

@yezz123
Copy link

yezz123 commented Oct 25, 2021

I guess pre-commit is a good suggestion to let the project clean, and also check the new PRs if they correspond to the linting rules.

For example:

hooks:
          - id: check-merge-conflict
          - id: check-added-large-files
          - id: check-ast
          - id: check-symlinks
          - id: trailing-whitespace
          - id: check-json
          - id: debug-statements
          - id: pretty-format-json

I will try to describe this issue in a PR.

@yezz123
Copy link
Author

yezz123 commented Oct 25, 2021

I just create the PR relate to this changes #345

@bourke bourke added this to Icebox in Mako prioritization Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant