python 3.7 regex change breaks postgresql COLLATE

[sqlalchemy-bot]

Migrated issue, originally created by Michael Bayer (@zzzeek)

see https://bugs.python.org/issue32998

patch:

diff --git a/lib/sqlalchemy/dialects/postgresql/base.py b/lib/sqlalchemy/dialects/postgresql/base.py
index 0cc7c307f..5ae27a996 100644
--- a/lib/sqlalchemy/dialects/postgresql/base.py
+++ b/lib/sqlalchemy/dialects/postgresql/base.py
@@ -1967,7 +1967,8 @@ class PGTypeCompiler(compiler.GenericTypeCompiler):
                 "[]" *
                 (type_.dimensions if type_.dimensions is not None else 1)
             )),
-            inner
+            inner,
+            count=1
         )
 

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

this was first in #4006

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Only replace first occurrence for COLLATE/ARRAY syntax

Fixed bug in Postgresql COLLATE / ARRAY adjustment first introduced
in 🎫4006 where new behaviors in Python 3.7 regular expressions
caused the fix to fail.

Change-Id: Ied3893d7cac210befa0277b55b3b895b0ba1f0d2
Fixes: #4208

→ dc117f8

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Only replace first occurrence for COLLATE/ARRAY syntax

Fixed bug in Postgresql COLLATE / ARRAY adjustment first introduced
in 🎫4006 where new behaviors in Python 3.7 regular expressions
caused the fix to fail.

Change-Id: Ied3893d7cac210befa0277b55b3b895b0ba1f0d2
Fixes: #4208
(cherry picked from commit 7300469)

→ cc6ec00

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Only replace first occurrence for COLLATE/ARRAY syntax

Fixed bug in Postgresql COLLATE / ARRAY adjustment first introduced
in 🎫4006 where new behaviors in Python 3.7 regular expressions
caused the fix to fail.

Change-Id: Ied3893d7cac210befa0277b55b3b895b0ba1f0d2
Fixes: #4208

→ 7300469