identity insert switch fails for INSERT with insert.values({col: <expr>}) only

[zzzeek]

pretty specific stuff

from sqlalchemy import Column
from sqlalchemy import create_engine
from sqlalchemy import Integer
from sqlalchemy import literal
from sqlalchemy.ext.declarative import declarative_base

Base = declarative_base()


class A(Base):
    __tablename__ = 'a'

    id = Column(Integer, primary_key=True)

e = create_engine("mssql+pyodbc://scott:tiger^5HHH@mssql2017:1433/test?driver=ODBC+Driver+13+for+SQL+Server", echo=True)
Base.metadata.drop_all(e)
Base.metadata.create_all(e)

with e.connect() as conn:
    # passes
    conn.execute(
        A.__table__.insert(),
        id=1
    )

    # passes
    conn.execute(
        A.__table__.insert().values(id=literal(2))
    )

    # passes
    conn.execute(
        A.__table__.insert().values({A.__table__.c.id: 3})
    )

    # fails
    conn.execute(
        A.__table__.insert().values({A.__table__.c.id: literal(4)})
    )

[zzzeek]

this is failing in the test suite as of c1f310d as we have a test running on that.

[sqla-tester]

Mike Bayer has proposed a fix for this issue in the master branch:

Set IDENTITY_INSERT for insert.values({column: expr}) https://gerrit.sqlalchemy.org/1133

[sqla-tester]

Mike Bayer has proposed a fix for this issue in the rel_1_2 branch:

Set IDENTITY_INSERT for insert.values({column: expr}) https://gerrit.sqlalchemy.org/1134