Error Message Formatting : Missing Bind Parameter

[natec425]

Hey hey,

I'm just looking for comments/interest on changing the error formatting for StatementError. I'm interested in making small changes at the two lines below:

• Change %r to %s so that multi-line SQL statements appear formatted in a way that would be more quickly recognized by its author.

sqlalchemy/lib/sqlalchemy/exc.py

Line 349 in 4d7ac4b

details.append("[SQL: %r]" % self.statement)

• Join on "\n" instead of " " in hopes of improved readability

sqlalchemy/lib/sqlalchemy/exc.py

Line 356 in 4d7ac4b

return " ".join(["(%s)" % det for det in self.detail] + details)

For example, this makes the difference between the two error messages:

sqlalchemy.exc.StatementError: (sqlalchemy.exc.InvalidRequestError) A value is required for bind parameter 'id' [SQL: 'select * from reviews where id = %(id)s'] (Background on this error at: http://sqlalche.me/e/cd3x)

(sqlalchemy.exc.InvalidRequestError) A value is required for bind parameter 'id' [SQL: 'select * from reviews where id = %(id)s'] (Background on this error at: http://sqlalche.me/e/cd3x)

becomes

sqlalchemy.exc.StatementError: (sqlalchemy.exc.InvalidRequestError) A value is required for bind parameter 'id'
[SQL: (select * from reviews where id = %(id)s)]
(Background on this error at: http://sqlalche.me/e/cd3x)

(sqlalchemy.exc.InvalidRequestError) A value is required for bind parameter 'id'
[SQL: (select * from reviews where id = %(id)s)]
(Background on this error at: http://sqlalche.me/e/cd3x)

If this sounds alright. I'd be happy to make a PR 😄

Thanks for your time.

[zzzeek]

looks nicer but I worry the use case of grepping logs might be impacted. though the error message itself is still staying on one line so maybe it wont be so bad. we're right at the edge of me wanting to release 1.3.0 final so, that's where it would have to be. I'd be happy to evaluate a PR to see what it ends up looking like.

[sqla-tester]

Nate Clark has proposed a fix for this issue in the master branch:

Issue #4500 : Change StatementError formatting (newlines and %s) https://gerrit.sqlalchemy.org/1136