Misleading documentation using assert statement for validation

[wyfo]

Validators documentation presents validators using assert statement to validate data. However, assert is a debug statement, which is disabled (and then validation using it) when run in optimized mode.

assert should only be used to ensure already trusted data, but I assume this is not the principal use case.
That's why the documentation should be updated to replace this statement by raising a ValueError instead. A note could be added to explain why assert is not the statement you should use in validation, excepted if you know what you are doing.

[CaselIT]

Hi,

Thanks for reporting this. If you want to provide a pull request, that would be great!

[sqla-tester]

jonathan vanasco has proposed a fix for this issue in the master branch:

Fixes: #5596 https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/3071