Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #11285 CONSTRAINT FOREIGN KEY ON DELETE was missing SET DEFAULT from mysql reflection #11368

Conversation

quentin-roche
Copy link

@quentin-roche quentin-roche commented May 8, 2024

CONSTRAINT FOREIGN KEY ON DELETE SET DEFAULT is missing from mysql reflection.

Description

This was discussed in issue 11285.

MySQL documentation for FOREIGN KEY Constraints.

I added the SET DEFAULT in the reflexion regex and modified one of the test case since both were testing for ON DELETE CASCADE.

Fixes: #11285

Checklist

This pull request is:

  • A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

CONSTRAINT FOREIGN KEY ON DELETE was missing SET DEFAULT in MySQL reflexion
@quentin-roche quentin-roche force-pushed the fix/missing-constraint-foreign-key-on-delete-set-default branch from e15ebea to dbd9c23 Compare May 8, 2024 08:56
@quentin-roche quentin-roche marked this pull request as ready for review May 8, 2024 08:57
@CaselIT
Copy link
Member

CaselIT commented May 8, 2024

thanks.
let's make it run the pipeline

@CaselIT CaselIT requested a review from sqla-tester May 8, 2024 10:48
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision dbd9c23 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change dbd9c23: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5297

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5297 has been merged. Congratulations! :)

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5298 has been merged. Congratulations! :)

sqlalchemy-bot pushed a commit that referenced this pull request May 22, 2024
Added missing foreign key reflection option ``SET DEFAULT``
in the MySQL and MariaDB dialects.

Fixes: #11285
Closes: #11368
Pull-request: #11368
Pull-request-sha: dbd9c23

Change-Id: If61d3365fc4271432d5591d1b50e10f4a1da9290
(cherry picked from commit 323a7dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL reflection CONSTRAINT FOREIGN KEY ON DELETE is missing SET DEFAULT
4 participants