Optimize has_intersection func

[artofhuman]

Optimize has_intersection function. It uses in few places, but even so it might be optimized. New version:

1. Does not allocate new set
2. A bit of performance speedup

from sqlalchemy import util

import timeit
import functools

a = {1, 2, 3}
b = [2, 3, 4]

t1 = timeit.Timer(functools.partial(util.has_intersection, a, b))
t2 = timeit.Timer(functools.partial(util.has_intersection2, a, b))

print("old", t1.timeit())
print("new", t2.timeit())


old 0.37196154199773446
new 0.29704541599494405

old 0.37331208398973104
new 0.29647241700149607

Description

Checklist

This pull request is:

• A documentation / typographical / small typing error fix
  • Good to go, no issue or tests are needed
• A short code fix
  • please include the issue number, and create an issue if none exists, which
    must include a complete example of the issue. one line code fixes without an
    issue and demonstration will not be accepted.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests. one line code fixes without tests will not be accepted.
• A new feature implementation
  • please include the issue number, and create an issue if none exists, which must
    include a complete example of how the feature would look.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests.

Have a nice day!

[CaselIT]

Thanks, the change does make sense. Maybe remove the TODO there too

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 258bf1a of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

New Gerrit review created for change 258bf1a: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5321

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5321 has been merged. Congratulations! :)

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/5323 has been merged. Congratulations! :)