Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow to generate wheel #5241

Merged
merged 5 commits into from Apr 13, 2020

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Apr 8, 2020

This runs after a release has been created

Currently this is still configured to target the test pypi. After a successful release and run it will be updated to target the real pypi

Closes #3747
Closes #4827

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

…d created

Change-Id: I916491f8f6bdbf7de7970a0ad4b24b9965003786
@zzzeek
Copy link
Member

zzzeek commented Apr 8, 2020

so I should merge this straight in right?

@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

I've asked for feedback in #5207 so maybe we could wait a could of days to see if anyone has some?

@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

Also seems that python 2.7 on ubuntu fails to install the wheel for some reason.

https://github.com/CaselIT/sqlalchemy/actions/runs/73872277

NOTE: python 3.5 is expected to fails since it currently fails the test on rel_13.

@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

The generated wheels are here
https://github.com/CaselIT/sqlalchemy/releases/tag/rel_1_3_16_wheel
And currently published on the test pypi:
https://test.pypi.org/project/SQLAlchemy/1.3.16.dev0/#files

@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

I need to figure out why it generates "dev0" builds

@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

I need to figure out why it generates "dev0" builds

setup.cfg has the section

[egg_info]
tag_build = dev

that is removed with

sed -i '/tag_build=dev/d' setup.cfg
sed -i '/tag_build = dev/d' setup.cfg

before releasing in the current release script.
I guess I should I add a step like this in the workflow, or there is an environment variable or flag that overrides it?

Change-Id: I547aecb28cda29607371138bf3a0c559a786c818
@CaselIT
Copy link
Member Author

CaselIT commented Apr 8, 2020

Updated build without dev0
https://github.com/CaselIT/sqlalchemy/releases/tag/rel_1_3_16_wheel_2
And currently published on the test pypi:
https://test.pypi.org/project/SQLAlchemy/1.3.16/#files

Change-Id: I5f1d888a13dbdf4c9ded85a6922c9ffcdaea5a0f
Change-Id: I67b524025467fc2ee1faf34f3fe241a19b9c72f3
Change-Id: I9bde5fb2cd9997c620d8ee3173fcd7fc6d80cae7
@CaselIT
Copy link
Member Author

CaselIT commented Apr 9, 2020

the last commit updates the linux workflow, so that python 2.7 wheels are build (both cp27m and cp27mu)

This was referenced Apr 11, 2020
@CaselIT
Copy link
Member Author

CaselIT commented Apr 13, 2020

I've asked for feedback in #5207 so maybe we could wait a could of days to see if anyone has some?

I guess we can merge this.

@zzzeek
Copy link
Member

zzzeek commented Apr 13, 2020

I just saw all the wheels, amazing!!!

@sqlalchemy-bot sqlalchemy-bot merged commit 6b56350 into sqlalchemy:master Apr 13, 2020
@CaselIT
Copy link
Member Author

CaselIT commented Apr 13, 2020

Nice, This should also go on rel_1.3

@CaselIT CaselIT deleted the add_releases_workflow branch April 17, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheels for all Windows wheels
3 participants