Add support for per file ignore using flake8 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if we keep flake8 as a required dependency, this may also be the solution for #13 |
- migrate to a package - vendor used flake8 parts instead of usig it as library, since it's interface is not stable - detect per file ignores - fix license in setup.py
CaselIT
force-pushed
the
per_file_ignore
branch
from
8013c66
to
3a066e7
Compare
|
@zzzeek updated, take a look |
CaselIT
commented
Feb 25, 2021
zzzeek
approved these changes
Mar 3, 2021
|
@zzzeek can you push the new version to pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zzzeek let me know what you think.
We could probably avoid importing flake8 by coping the code to parse the per-file-ignores, since it's a single function.