Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken grammar of LIKELIHOOD #650

Merged
merged 1 commit into from
Dec 17, 2022
Merged

fix: broken grammar of LIKELIHOOD #650

merged 1 commit into from
Dec 17, 2022

Conversation

bajinsheng
Copy link
Collaborator

To avoid the grammar error: The second argument of LIKELIHOOD must be a float number within 0.0 -1.0

@bajinsheng bajinsheng linked an issue Dec 17, 2022 that may be closed by this pull request
Support QPG #641
Closed
@bajinsheng bajinsheng enabled auto-merge (squash) December 17, 2022 09:42
@bajinsheng
Copy link
Collaborator Author

This fix works for SQLite >=3.6.0

mrigger
mrigger reviewed Dec 17, 2022
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume with this change, we can also remove the corresponding expected error below?

sqlancer/src/sqlancer/sqlite3/SQLite3Errors.java

Line 24 in b5eb215

errors.add("second argument to likelihood() must be a constant between 0.0 and 1.0");

@bajinsheng
Copy link
Collaborator Author

Oh yes. Didn't notice that.

mrigger
mrigger approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@mrigger mrigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bajinsheng bajinsheng merged commit ca70c6a into sqlancer:master Dec 17, 2022
albertZhangTJ pushed a commit to albertZhangTJ/sqlancer-lancerfuzz that referenced this pull request Dec 19, 2022
@bajinsheng @albertZhangTJ
fix: broken grammar of LIKELIHOOD (sqlancer#650)
da53c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrigger mrigger mrigger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support QPG
2 participants
@bajinsheng @mrigger