Query Plan Guidance Framework #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bajinsheng
commented
Dec 18, 2022
•
bajinsheng
commented
- Add the framework of Query Plan Guidance (QPG).
- Add the QPG implementation of SQLite CockroachDB and TiDB.
Closed
mrigger
reviewed
Dec 18, 2022
mrigger
reviewed
Dec 18, 2022
mrigger
reviewed
Dec 19, 2022
| @@ -285,4 +287,57 @@ public String getDBMSName() { | |||
| return "cockroachdb"; | |||
| } | |||
|
|
|||
| @Override | |||
| public String getQueryPlan(String selectStr, CockroachDBGlobalState globalState) throws Exception { | |||
There was a problem hiding this comment.
It would be great to add a couple of test cases (perhaps in a future PR) for parsing the query plans to ensure that everything still works after updating the database systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.