MySQL Join implementation #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrigger
reviewed
Mar 18, 2024
| @@ -148,7 +140,7 @@ private static int mapActions(MySQLGlobalState globalState, Action a) { | |||
|
|
|||
| @Override | |||
| public void generateDatabase(MySQLGlobalState globalState) throws Exception { | |||
| while (globalState.getSchema().getDatabaseTables().size() < Randomly.smallNumber() + 1) { | |||
| while (globalState.getSchema().getDatabaseTables().size() < Randomly.getNotCachedInteger(1, 6)) { | |||
There was a problem hiding this comment.
6 tables seem like a lot here and might have a detrimental effect on performance. Could we perhaps set the limit depending on the test oracle here?
mrigger
reviewed
Mar 18, 2024
| @@ -148,7 +140,7 @@ private static int mapActions(MySQLGlobalState globalState, Action a) { | |||
|
|
|||
| @Override | |||
| public void generateDatabase(MySQLGlobalState globalState) throws Exception { | |||
| while (globalState.getSchema().getDatabaseTables().size() < Randomly.smallNumber() + 1) { | |||
| while (globalState.getSchema().getDatabaseTables().size() < Randomly.getNotCachedInteger(1, 2)) { | |||
There was a problem hiding this comment.
I think we could just leave Randomly.smallNumber() + 1, which might sometimes generate more tables than 2?
There was a problem hiding this comment.
No. Small number returns (-1, 1) with a Gaussian distribution, which means in most situations, there is only one table.
There was a problem hiding this comment.
Thanks for the clarification!
albertZhangTJ
pushed a commit
to albertZhangTJ/sqlancer-lancerfuzz
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #918