Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL] Add bugs 114533 and 114544 #938

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

malwaregarry
Copy link
Contributor

@malwaregarry malwaregarry commented Apr 1, 2024

The checks for MySQL were detecting an error caused by Java parsing an invalid string. I fixed this by passing the exception up as an SQLException and adding a new ExpectedError

There is still a potential bug reported, which I will investigate after this PR is merged.
https://bugs.mysql.com/bug.php?id=114533
https://bugs.mysql.com/bug.php?id=114534

@mrigger
Copy link
Contributor

mrigger commented Apr 1, 2024

This looks like a bug in the JDBC driver to me. I think it would be ideal to reduce this case, report it to MySQL (if we believe it's indeed a bug), and then add it as a known bug, rather than an expected error.

@malwaregarry
Copy link
Contributor Author

malwaregarry commented Apr 2, 2024

DROP DATABASE IF EXISTS database3;
CREATE DATABASE database3;
USE database3;
CREATE TABLE IF NOT EXISTS t0(c0 FLOAT ZEROFILL);
INSERT INTO t0(c0) VALUES("-0");
SELECT t0.c0 FROM t0;  --0000000000-0

I reduced the error to this. Seems to be because of a column with ZEROFILL and a negative 0.

bug report: https://bugs.mysql.com/bug.php?id=114533

@malwaregarry malwaregarry force-pushed the mysql-ci branch 2 times, most recently from cddcda6 to ccb3d29 Compare April 3, 2024 12:37
@malwaregarry malwaregarry changed the title [MySQL] Add ExpectedError for invalid string returned [MySQL] Add bugs 114533 and 114544 Apr 3, 2024
@malwaregarry
Copy link
Contributor Author

@mrigger the known bugs have been added

@mrigger mrigger merged commit d6ab996 into sqlancer:main Apr 3, 2024
13 of 21 checks passed
@mrigger
Copy link
Contributor

mrigger commented Apr 3, 2024

Great to see the MySQL gate passing again!

@mrigger
Copy link
Contributor

mrigger commented Apr 3, 2024

It seems there is still another location where the JDBC issue is triggered: https://github.com/sqlancer/sqlancer/actions/runs/8505272902/job/23293481262.

@malwaregarry malwaregarry deleted the mysql-ci branch April 6, 2024 01:55
@malwaregarry malwaregarry restored the mysql-ci branch April 6, 2024 01:55
@malwaregarry malwaregarry deleted the mysql-ci branch April 6, 2024 01:56
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request Apr 6, 2024
* Pass exception from ResultSet up as SQLException

* [MySQL] Add bugs 114533 and 114534
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request Apr 11, 2024
* Pass exception from ResultSet up as SQLException

* [MySQL] Add bugs 114533 and 114534
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request May 18, 2024
* Pass exception from ResultSet up as SQLException

* [MySQL] Add bugs 114533 and 114534
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request May 26, 2024
* Pass exception from ResultSet up as SQLException

* [MySQL] Add bugs 114533 and 114534
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants