[SQLite3] Use generic TLP Where oracle #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malwaregarry
force-pushed
the
sqlite-tlp-where
branch
from
c7788bf
to
17f7d3e
Compare
malwaregarry
changed the title
mrigger
approved these changes
Jun 19, 2024
mrigger
reviewed
Jun 19, 2024
| public void check() throws SQLException { | ||
| S s = state.getSchema(); | ||
| AbstractTables<T, C> targetTables = TestOracleUtils.getRandomTableNonEmptyTables(s); | ||
| gen = gen.setTablesAndColumns(targetTables); |
There was a problem hiding this comment.
Not related to this PR, but I was a bit confused by this. The set somewhat suggests that we set a value in the existing generator, but actually, we create a new generator. Can we reflect this in the naming of the methods? E.g., newWithTablesandColumns or copyWithTablesAndColumns or so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased from #941