Add support for BETWEEN sqlc.arg(min) AND sqlc.arg(max)

issue #2277
sqlc-dev · Jun 27, 2023 · 203d8b5 · 203d8b5
1 parent 7e81fac
commit 203d8b5
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 1 deletion.
diff --git a/internal/endtoend/testdata/between_args/mysql/go/query.sql.go b/internal/endtoend/testdata/between_args/mysql/go/query.sql.go
diff --git a/internal/endtoend/testdata/between_args/mysql/query.sql b/internal/endtoend/testdata/between_args/mysql/query.sql
@@ -19,3 +19,8 @@ WHERE   products.price BETWEEN ? AND ?;
 SELECT  *
 FROM    products as p
 WHERE   p.price BETWEEN ? AND ?;
+
+-- name: GetBetweenPricesNamed :many
+SELECT  *
+FROM    products
+WHERE   price BETWEEN sqlc.arg(min_price) AND sqlc.arg(max_price);
diff --git a/internal/sql/astutils/rewrite.go b/internal/sql/astutils/rewrite.go
@@ -400,7 +400,9 @@ func (a *application) apply(parent ast.Node, name string, iter *iterator, n ast.
 		a.apply(n, "Refassgnexpr", nil, n.Refassgnexpr)
 
 	case *ast.BetweenExpr:
-		// pass
+		a.apply(n, "Expr", nil, n.Expr)
+		a.apply(n, "Left", nil, n.Left)
+		a.apply(n, "Right", nil, n.Right)
 
 	case *ast.BitString:
 		// pass