-
Notifications
You must be signed in to change notification settings - Fork 755
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(compiler): Fix validation of GROUP BY on field aliases (#1348)
- Loading branch information
Showing
11 changed files
with
478 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
internal/endtoend/testdata/valid_group_by_reference/mysql/go/db.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
internal/endtoend/testdata/valid_group_by_reference/mysql/go/models.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
110 changes: 110 additions & 0 deletions
110
internal/endtoend/testdata/valid_group_by_reference/mysql/go/query.sql.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
47 changes: 47 additions & 0 deletions
47
internal/endtoend/testdata/valid_group_by_reference/mysql/query.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
CREATE TABLE authors ( | ||
id BIGINT NOT NULL AUTO_INCREMENT PRIMARY KEY, | ||
name text NOT NULL, | ||
bio text, | ||
UNIQUE(name) | ||
); | ||
|
||
-- name: ListAuthors :many | ||
SELECT id, name as full_name, bio | ||
FROM authors | ||
GROUP BY full_name; | ||
|
||
-- name: ListAuthorsIdenticalAlias :many | ||
SELECT id, name as name, bio | ||
FROM authors | ||
GROUP BY name; | ||
|
||
|
||
-- https://github.com/kyleconroy/sqlc/issues/1315 | ||
|
||
CREATE TABLE IF NOT EXISTS weather_metrics | ||
( | ||
time TIMESTAMP NOT NULL, | ||
timezone_shift INT NULL, | ||
city_name TEXT NULL, | ||
temp_c FLOAT NULL, | ||
feels_like_c FLOAT NULL, | ||
temp_min_c FLOAT NULL, | ||
temp_max_c FLOAT NULL, | ||
pressure_hpa FLOAT NULL, | ||
humidity_percent FLOAT NULL, | ||
wind_speed_ms FLOAT NULL, | ||
wind_deg INT NULL, | ||
rain_1h_mm FLOAT NULL, | ||
rain_3h_mm FLOAT NULL, | ||
snow_1h_mm FLOAT NULL, | ||
snow_3h_mm FLOAT NULL, | ||
clouds_percent INT NULL, | ||
weather_type_id INT NULL | ||
); | ||
|
||
-- name: ListMetrics :many | ||
SELECT time_bucket('15 days', time) AS bucket, city_name, AVG(temp_c) | ||
FROM weather_metrics | ||
WHERE DATE_SUB(NOW(), INTERVAL 6 MONTH) | ||
GROUP BY bucket, city_name | ||
ORDER BY bucket DESC; |
12 changes: 12 additions & 0 deletions
12
internal/endtoend/testdata/valid_group_by_reference/mysql/sqlc.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"version": "1", | ||
"packages": [ | ||
{ | ||
"path": "go", | ||
"engine": "mysql", | ||
"name": "querytest", | ||
"schema": "query.sql", | ||
"queries": "query.sql" | ||
} | ||
] | ||
} |
29 changes: 29 additions & 0 deletions
29
internal/endtoend/testdata/valid_group_by_reference/postgresql/go/db.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
34 changes: 34 additions & 0 deletions
34
internal/endtoend/testdata/valid_group_by_reference/postgresql/go/models.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.