Skip to content

Commit

Permalink
docs: warn about golang-migrate file order (#1302)
Browse files Browse the repository at this point in the history
* docs: warn about golang-migrate file order
  • Loading branch information
senekor committed Nov 24, 2021
1 parent 4bbe1ca commit 7bb2352
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions docs/howto/ddl.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,24 @@ type Comment struct {

### golang-migrate

Warning: [golang-migrate specifies](https://github.com/golang-migrate/migrate/blob/master/MIGRATIONS.md#migration-filename-format) that the version number in the migration file name is to be interpreted numerically. However, sqlc executes the migration files in **lexicographic** order. If you choose to simply enumerate your migration versions, make sure to prepend enough zeros to the version number to avoid any unexpected behavior.

Probably doesn't work as intended:
```
1_initial.up.sql
...
9_foo.up.sql
# this migration file will be executed BEFORE 9_foo
10_bar.up.sql
```
Works as was probably intended:
```
001_initial.up.sql
...
009_foo.up.sql
010_bar.up.sql
```

In `20060102.up.sql`:

```sql
Expand Down

0 comments on commit 7bb2352

Please sign in to comment.