fix(mysql)!: Generate unsigned param (#2522)

A fix to the original change (#1746) that added support for unsigned integers. While this is a breaking change, it's impact should be smaller than the previous change. * fix missing unsigned param * add end-to-end test for unsigned_params
sqlc-dev · Jul 25, 2023 · e3c657d · e3c657d
1 parent b9c3af4
commit e3c657d
Show file tree

Hide file tree

Showing 7 changed files with 79 additions and 1 deletion.
diff --git a/internal/compiler/resolve.go b/internal/compiler/resolve.go
@@ -458,6 +458,7 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 						OriginalName: c.Name,
 						DataType:     dataType(&c.Type),
 						NotNull:      p.NotNull(),
+						Unsigned:     c.IsUnsigned,
 						IsArray:      c.IsArray,
 						Table:        &ast.TableName{Schema: schema, Name: rel},
 						Length:       c.Length,

diff --git a/internal/endtoend/testdata/schema_scoped_create/mysql/go/query.sql.go b/internal/endtoend/testdata/schema_scoped_create/mysql/go/query.sql.go
diff --git a/internal/endtoend/testdata/unsigned_params/mysql/go/db.go b/internal/endtoend/testdata/unsigned_params/mysql/go/db.go
diff --git a/internal/endtoend/testdata/unsigned_params/mysql/go/models.go b/internal/endtoend/testdata/unsigned_params/mysql/go/models.go
diff --git a/internal/endtoend/testdata/unsigned_params/mysql/go/query.sql.go b/internal/endtoend/testdata/unsigned_params/mysql/go/query.sql.go
diff --git a/internal/endtoend/testdata/unsigned_params/mysql/query.sql b/internal/endtoend/testdata/unsigned_params/mysql/query.sql
@@ -0,0 +1,4 @@
+CREATE TABLE foo (id INT UNSIGNED NOT NULL);
+
+-- name: CreateFoo :exec
+INSERT INTO foo (id) VALUES (?);
diff --git a/internal/endtoend/testdata/unsigned_params/mysql/sqlc.json b/internal/endtoend/testdata/unsigned_params/mysql/sqlc.json
@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "path": "go",
+      "engine": "mysql",
+      "name": "querytest",
+      "schema": "query.sql",
+      "queries": "query.sql"
+    }
+  ]
+}