fix(engine/sqlite): fix grammer to avoid missing join_constraint (#2732)

close #2729

ANTLR's API has difficulty handling the case where there is no join_constraint
corresponding to join_operator in join_clause, so an empty join_constraint is accepted.

It is defined as such in the sqlite documentation.
https://www.sqlite.org/syntax/join-clause.html
https://www.sqlite.org/syntax/join-constraint.html

internal/endtoend/testdata/join_where_clause/mysql/query.sql

@@ -11,4 +11,10 @@ WHERE owner = ?;
 SELECT foo.*
 FROM foo
 JOIN bar ON bar.id = ?
-WHERE owner = ?;
+WHERE owner = ?;
+
+-- name: JoinNoConstraints :many
+SELECT foo.*
+FROM foo
+CROSS JOIN bar
+WHERE bar.id = ? AND owner = ?;

internal/endtoend/testdata/join_where_clause/postgresql/pgx/v4/query.sql

@@ -11,4 +11,10 @@ WHERE owner = $1;
 SELECT foo.*
 FROM foo
 JOIN bar ON bar.id = $2
-WHERE owner = $1;
+WHERE owner = $1;
+
+-- name: JoinNoConstraints :many
+SELECT foo.*
+FROM foo
+CROSS JOIN bar
+WHERE bar.id = $2 AND owner = $1;

internal/endtoend/testdata/join_where_clause/postgresql/pgx/v5/query.sql

@@ -11,4 +11,10 @@ WHERE owner = $1;
 SELECT foo.*
 FROM foo
 JOIN bar ON bar.id = $2
-WHERE owner = $1;
+WHERE owner = $1;
+
+-- name: JoinNoConstraints :many
+SELECT foo.*
+FROM foo
+CROSS JOIN bar
+WHERE bar.id = $2 AND owner = $1;

internal/endtoend/testdata/join_where_clause/postgresql/stdlib/query.sql

@@ -11,4 +11,10 @@ WHERE owner = $1;
 SELECT foo.*
 FROM foo
 JOIN bar ON bar.id = $2
-WHERE owner = $1;
+WHERE owner = $1;
+
+-- name: JoinNoConstraints :many
+SELECT foo.*
+FROM foo
+CROSS JOIN bar
+WHERE bar.id = $2 AND owner = $1;

internal/endtoend/testdata/join_where_clause/sqlite/query.sql

@@ -11,4 +11,10 @@ WHERE owner = ?;
 SELECT foo.*
 FROM foo
 JOIN bar ON bar.id = ?
-WHERE owner = ?;
+WHERE owner = ?;
+
+-- name: JoinNoConstraints :many
+SELECT foo.*
+FROM foo
+CROSS JOIN bar
+WHERE bar.id = ? AND owner = ?;

internal/engine/sqlite/parser/SQLiteParser.g4

@@ -398,7 +398,7 @@ select_stmt:
 ;
 
 join_clause:
-    table_or_subquery (join_operator table_or_subquery join_constraint?)*
+    table_or_subquery (join_operator table_or_subquery join_constraint)*
 ;
 
 select_core:
@@ -454,8 +454,8 @@ join_operator:
 ;
 
 join_constraint:
-    ON_ expr
-    | USING_ OPEN_PAR column_name ( COMMA column_name)* CLOSE_PAR
+    (ON_ expr
+    | USING_ OPEN_PAR column_name ( COMMA column_name)* CLOSE_PAR)?
 ;
 
 compound_operator: