Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Type Alias #1866

Closed
christoph-pflueger opened this issue Sep 28, 2022 · 1 comment
Closed

Unable to Type Alias #1866

christoph-pflueger opened this issue Sep 28, 2022 · 1 comment
Labels

Comments

@christoph-pflueger
Copy link

christoph-pflueger commented Sep 28, 2022

Version

1.15.0

What happened?

Example Query:

-- name: CheckIfSomeRandomColumnIsNotNull :one
SELECT
  `some_random_column` IS NOT NULL AS `is_some_random_column_not_null`
FROM
  `example`
WHERE
  `id` = ?;

Results in:

type CheckIfSomeRandomColumnIsNotNullRow struct {
	IsSomeRandomColumnNotNull interface{}
}

Every attempt to use ::bool to type the struct field correctly resulted in a syntax error.

Relevant log output

No response

Database schema

CREATE TABLE `example` (
  `id` bigint unsigned NOT NULL AUTO_INCREMENT,
  `some_random_column` bigint unsigned DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=10 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

MySQL

What type of code are you generating?

Go

@christoph-pflueger christoph-pflueger added bug Something isn't working triage New issues that hasn't been reviewed labels Sep 28, 2022
kyleconroy pushed a commit that referenced this issue Jul 30, 2023
What is this

As the title said, this PR wants to add support for CAST function in MySQL.

This PR is based from PR by @ryanpbrewster here (which unfortunately he didn't send here, and only exist in his repository).
Why is this PR created

Currently sqlc unable to infer the correct type from SQL function like MAX, MIN, SUM, etc. For those function, sqlc will return its value as interface{}. This behavior can be seen in this playground.

As workaround, it advised to use CAST function to explicitly tell what is the type for that column, as mentioned in #1574.

Unfortunately, currently sqlc only support CAST function in PostgreSQL and not in MySQL. Thanks to this, right now MySQL users have to parse the interface{} manually, which is not really desirable.
What does this PR do?

    Implement convertFuncCast function for MySQL.
    Add better nil pointer check in some functions that related to convertFuncCast.

I haven't write any test because I'm not sure how and where to put it. However, as far as I know the code that handle ast.TypeCast for PostgreSQL also don't have any test, so I guess it's fine 🤷‍♂️
Related issues

Support CAST ... AS #687, which currently is the oldest MySQL issue that still opened.
Using MYSQL functions ( CONVERT and CAST) result in removing column from struct #1622
Unable to Type Alias #1866
sum in select result in model field type interface{} #1901
MIN() returns an interface{} #1965
@kyleconroy
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants