Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): test-endtoend working as intended #1488

Closed
wants to merge 1 commit into from

Conversation

sbres
Copy link
Contributor

@sbres sbres commented Mar 15, 2022

The cd was one level too deep and was not running the tests
Also added added logging of the error on generation to help debug

The cd was one level too deep and was not running the tests
@sbres sbres mentioned this pull request Mar 16, 2022
1 task
@kyleconroy
Copy link
Collaborator

I should probably add a comment to the Makefile, but this is currently working as intended. The build-endtoend and test-endtoend targets build and run the tests for the generated code in endtoend/testdata. test-endtoend is not meant to run the end to end tests. Those are run using make test.

@kyleconroy kyleconroy closed this Mar 16, 2022
@sbres
Copy link
Contributor Author

sbres commented Mar 16, 2022

I'm not sure what you are testing with test-endtoend then.
As there is not a single test inside the testdata directory, is it just there to be sure the files in testdata are valid go files ?

@kyleconroy
Copy link
Collaborator

kyleconroy commented Mar 16, 2022

As there is not a single test inside the testdata directory, is it just there to be sure the files in testdata are valid go files ?

That's a very good point.

$ find internal/endtoend/testdata/ | grep _test
# nothing

@sbres
Copy link
Contributor Author

sbres commented Mar 17, 2022

I have no idea why make test failed the first time I tried that sent me on this tangent.

make test is correctly running the endtoend tests and does not need the db 👍

@sbres sbres deleted the fix/makefile-test-endtoend branch March 17, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants