fix citext resolution issues #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies if I jumped the gun on this one since it is still in triage. I was experiencing the issue as well, so I thought I'd submit a PR. |
kyleconroy
reviewed
Aug 29, 2022
|
@kyleconroy I've added a few e2e tests, sorry it took me so long to get around to this. This should be good to go |
|
Cannot use sqlc because of citext not supported as string. Is there a chance to see patch merged soon ? |
|
@colbee1 This will be released in v1.19.0, which is slated for July. |
|
@colbee1 I think for now you could just use the following (I actually use this override): version: "2"
sql:
- engine: "postgresql"
schema: ...
queries: ...
gen:
go:
out: ...
overrides:
- db_type: "citext"
go_type: "string" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1581 .
I just added
citextto the switch so that it would resolve tostring, although this might not be the best solution.I looked around, and it seems that
hstorehas similar code and sincehstoreandcitextboth are extensions that live inpg_catalogthis seems to be in the spirit of the previous solutions.