New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CASE-ELSE clause is not properly parsed when a value is constant #2238

Merged

kyleconroy merged 2 commits into sqlc-dev:main from nozaq:fix-case-else

Apr 28, 2023

Contributor

nozaq commented Apr 28, 2023

Fixes #2237

This PR contains the following changes.

Parse ELSE clause value as a constant instead of a type name when a node is ast.A_Const.
Add a test case for testing CASE expression with TEXT values.
Fix an error message when fails to parse the type name.

nozaq added 2 commits

April 28, 2023 15:25


          fix: CASE-ELSE clause is not properly parsed when a value is constant

9f3aab3


          fix: error message when failed to parse a type name

bb7b1b1

nozaq changed the title ~~Fix case else~~ fix: CASE-ELSE clause is not properly parsed when a value is constant

kyleconroy merged commit 5555393 into sqlc-dev:main

6 checks passed

nozaq deleted the fix-case-else branch

April 28, 2023 21:44

Sub6Resources mentioned this pull request

CASE WHEN does not work in SELECT field #2261

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment