Merge branch 'nuumio-KeyMaterialSanitation'

sqlcipher · Oct 17, 2018 · cc31191 · cc31191
2 parents f2fd709 + 4c6f41c
commit cc31191
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/android-database-sqlcipher/src/main/java/net/sqlcipher/database/SQLiteDatabase.java b/android-database-sqlcipher/src/main/java/net/sqlcipher/database/SQLiteDatabase.java
@@ -37,6 +37,7 @@
 import java.nio.charset.Charset;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -118,9 +119,7 @@ public void changePassword(String password) throws SQLiteException {
         if (password != null) {
           byte[] keyMaterial = getBytes(password.toCharArray());
           rekey(keyMaterial);
-          for(byte data : keyMaterial) {
-            data = 0;
-          }
+          Arrays.fill(keyMaterial, (byte) 0);
         }
     }
 
@@ -143,9 +142,7 @@ public void changePassword(char[] password) throws SQLiteException {
         if (password != null) {
           byte[] keyMaterial = getBytes(password);
           rekey(keyMaterial);
-          for(byte data : keyMaterial) {
-            data = 0;
-          }
+          Arrays.fill(keyMaterial, (byte) 0);
         }     
     }
 
@@ -2537,9 +2534,7 @@ public void run() {
         }
       }
       if(keyMaterial != null && keyMaterial.length > 0) {
-        for(byte data : keyMaterial) {
-          data = 0;
-        }
+        Arrays.fill(keyMaterial, (byte) 0);
       }
     }