Changes to support custom database corruption error handler #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 28, 2015 11:54
…d() against database not opened
…e database separated out
Add additional safeguards to public SQLiteDatabase.markTableSyncable() functions in case the database is not opened. NOTE: The DefaultDatabaseErrorHandler follows the existing implementation from SQLiteDatabase.onCorruption() which is to close the database object and then delete it. This is different from the AOSP version of DefaultDatabaseErrorHandler.java which also attempts to delete all attached database files. FUTURE/TBD I am not sure if we want to do this or not.
This was referenced Aug 28, 2015
Merged
developernotes
added a commit
that referenced
this pull request
Aug 28, 2015
Changes to support custom database corruption error handler
|
Thanks! Did you get the test changes in sqlcipher/sqlcipher-android-tests#9? |
|
Yes I just merged in the tests as well - thanks @brodybits! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am also pushing the new tests of this feature. Please let me know if you have any questions. Ref: #169