Rename libs and related products from 'sqlite3' to 'sqlcipher'.

[petterreinholdtsen]

Patch by Hans-Christoph Steiner hans@eds.org.

Patch has been used by Debian package for a while, see https://udd.debian.org/patches.cgi?src=sqlcipher&version=3.4.1-2 .

[sjlombardo]

Hello @petterreinholdtsen - we already committed a change requested by debian back in 226e797 to rename build products to "sqlcipher" from "sqlite3". However, we deliberately chose not to adjust the version numbers reported by the library. It is important for many applications to be able to determine which version of SQLite they are dealing with. Having SQLCipher report something different could introduce major issues. The supported way for an application to determine what version of SQLCipher is in use PRAGMA cipher_version. In addition, the SQLCipher CLI reports the SQLCipher version in the first line of output. This has been universally established outside of debian for a very long time, and we don't plan on adjusting that at this time.

[petterreinholdtsen]

[Stephen Lombardo]

However, we deliberately chose not to adjust the version numbers reported by the library. It is important for many applications to be able to determine which version of SQLite they are dealing with. Having SQLCipher report something different could introduce major issues.

I tracked down the rationale for this change to <URL: https://bugs.debian.org/776987 > from 2015.

…

-- Happy hacking Petter Reinholdtsen

[sjlombardo]

Hello @petterreinholdtsen - I have reviewed the thread with additional context. This patch was to fix a problem introduced by a different Debian patch, not a problem in SQLCipher. The official SQLCipher releases have never modified the contents of the VERSION file - it will always report the proper SQLite version. However, a change was introduced in the Debian package to replace the VERSION file contents with the SQLCipher version instead of the SQLite version. That change was inadvisable, and as noted above, we did not apply that change to SQLCipher. It broke things for Debian and required a patchwork around that problem.

Our advise here would be to revert any changes / patches that modify VERSION. Stick with the official VERSION file and the built in facilities inside SQLCipher for checking the SQLCipher versions.